Prevent to always create a run #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-cty
force-pushed
the
feat/api_cleaning
branch
from
270b08a to
eb2986d
Compare
inimaz
requested changes
Apr 3, 2025
There was a problem hiding this comment.
Thanks @benoit-cty! Maybe we can remove the call to self._create_run() in the __init__? I see that we create the run anyhow if not present in the add_emissions See here/
benoit-cty
force-pushed
the
feat/api_cleaning
branch
from
eb2986d to
199f1b4
Compare
Well, I think not having a run_id in I prefer the explicit way of not asking to add a run. |
inimaz
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Thanks @benoit-cty ! With this, the API client will be in better shape. I mentioned a minor comment
benoit-cty
force-pushed
the
feat/api_cleaning
branch
from
199f1b4 to
23cb32f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ApiClientclass is creating a run in init. But when we are using it only to get data it create useless entry in the database.And now that the new API is in production, we could remove the warning.